Set init-justify to no in gcos-strict.conf #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitMensch
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Nice, GCOS is correct per COBOL then (this is the single place I'm currently aware of where IBM does something explicit specified to be different than the COBOL standard - nearly all other "possible issues" are about undefined behavior).
Your change looks good, but please adjust the copyright year on config/Changelog as well, then that's good for upstream.
|
checked in with r5420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing on GCOS, I confirm we should set init-justify to no.
(yeah, a PR for this is maybe a bit too much ;))