Fixes #4033 [bug] Dont reset downloadcounter when editting files #4074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… preserving count when file is replaced
| @@ -241,10 +241,6 @@ export class ResearchStore extends ModuleStore { | |||
| logger.debug('upload images ok') | |||
| this.updateUpdateUploadStatus('Images') | |||
|
|
|||
| if ((update.files && update.files.length) || update.fileLink) { | |||
| updateWithMeta.downloadCount = 0 | |||
There was a problem hiding this comment.
ahhhhh nice find!!!!!
|
Awesome. Thanks @ebradbury. If you see the checks the linter is currently failing. Running |
onearmy-community-platform
|
||||||||||||||||||||||||||||
| Project |
onearmy-community-platform
|
| Branch Review |
pull/4074
|
| Run status |
|
| Run duration | 05m 28s |
| Commit |
|
| Committer | Elliot Bradbury |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
78
|
| View all changes introduced in this branch ↗︎ | |
|
@allcontributors add @ebradbury for code |
|
I've put up a pull request to add @ebradbury! 🎉 |
|
🎉 This PR is included in version 2.27.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Replacing a file on a research update resets the file download counter.
What is the new behavior?
The research update file download counter is not reset when the file is replaced.
Describe the new behaviour
If useful, provide screenshot or capture to highlight main changes
Does this PR introduce a breaking change?
Git Issues
Closes #4033
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
developmentchannel.