Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework change email and password forms #4078

Conversation

CrowsVeldt
Copy link

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix (fixes an issue)
  • Feature (adds functionality)
  • Code style update
  • Refactoring (no functional changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Describe the new behaviour
Screenshot 2025-01-14 at 18-28-27 Precious Plastic
Screenshot 2025-01-14 at 18-29-10 Precious Plastic

Does this PR introduce a breaking change?

  • Yes
  • No

Git Issues

Closes #3786

What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

@CrowsVeldt CrowsVeldt requested a review from a team as a code owner January 16, 2025 14:21
@CrowsVeldt
Copy link
Author

Hey, @benfurber. Here's the PR.

I haven't added tests or stories yet. I will work on it, but my schedule is unstable right now so I can't promise when it'll get done.

I also wanted to ask your opinion on the various imports that I just added a bunch of '../'s to.
I think it might make sense for the components to receive the labels as props, but it seems to awkward to do the same for all of them.

I'm happy to make and amendments and revisions necessary.

@benfurber
Copy link
Member

Hey @CrowsVeldt thanks for the first draft of this. So the components in the library should only import other component library items - not from the main app. So I either more or less should be in the library. In this instance it's probably less, e.g. the only thing that should be in the library is a new accordion component - everything to do with the form, etc. can stay where it is.

@CrowsVeldt
Copy link
Author

Hey @CrowsVeldt thanks for the first draft of this. So the components in the library should only import other component library items - not from the main app. So I either more or less should be in the library. In this instance it's probably less, e.g. the only thing that should be in the library is a new accordion component - everything to do with the form, etc. can stay where it is.

OK, thanks! I'll work on it now.

@CrowsVeldt
Copy link
Author

I think I got it right this time. Starting a new PR to prevent making a mess of the commit history.

@CrowsVeldt CrowsVeldt closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat: add accordion for settings form
2 participants