feat: Add loading state to ImageGallery (#3462) #4084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onearmy-community-platform
|
||||||||||||||||||||||||||||
| Project |
onearmy-community-platform
|
| Branch Review |
pull/4084
|
| Run status |
|
| Run duration | 05m 34s |
| Commit |
|
| Committer | Johannes Roß |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
81
|
| View all changes introduced in this branch ↗︎ | |
benfurber
added
the
Review allow-preview ✅
benfurber
force-pushed
the
add-loading-state-to-ImageGallery-3462
branch
from
6c0c3e1 to
db90f95
Compare
benfurber
force-pushed
the
add-loading-state-to-ImageGallery-3462
branch
from
db90f95 to
2548f75
Compare
benfurber
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
Feature (adds functionality)
What is the current behavior?
Images loading in are displayed while they are uncompleted.
What is the new behavior?
When Images load in, there is now the Applications Load Spinner.
Does this PR introduce a breaking change?
No
Git Issues
Closes #3462
Additional Information
I've decided to move the Loadingspinner logic for the thumbnails into their own component, for a couple of reasons:
packages/components/src/MapFilterList/MapFilterList.tsxandpackages/components/src/MemberTypeVerticalList/MemberTypeVerticalList.client.tsxI've only noticed now. I'm guessing they got in while linting/formatting (yarn format && yarn lint).