Skip to content

Commit

Permalink
Merge pull request #708 from OSMCha/fix/order_by+tags
Browse files Browse the repository at this point in the history
Remove order by id options + fix Tags dropdown loading
  • Loading branch information
willemarcel authored Feb 16, 2024
2 parents d16771e + 24f7ab9 commit 89c13b8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
4 changes: 3 additions & 1 deletion src/components/changeset/tags.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ export class Tags extends React.PureComponent {
return this.tagsData.promise
.then(json => {
let data = {};
let selectData = json.filter(d => d.is_visible && d.for_changeset);
let selectData = json.results.filter(
d => d.is_visible && d.for_changeset
);

selectData.forEach(d => {
data[d.name] = { ...d, value: d.id, label: d.name };
Expand Down
8 changes: 0 additions & 8 deletions src/config/filters.json
Original file line number Diff line number Diff line change
Expand Up @@ -382,10 +382,6 @@
"display": "Order by",
"type": "radio",
"options": [
{
"label": "Ascending ID",
"value": "id"
},
{
"label": "Ascending Date",
"value": "date"
Expand All @@ -410,10 +406,6 @@
"label": "Ascending number of comments",
"value": "comments_count"
},
{
"label": "Descending ID",
"value": "-id"
},
{
"label": "Descending Date",
"value": "-date"
Expand Down

0 comments on commit 89c13b8

Please sign in to comment.