Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate JSON deserialization #4

Open
ivanovmg opened this issue Dec 28, 2024 · 0 comments · May be fixed by #5
Open

Duplicate JSON deserialization #4

ivanovmg opened this issue Dec 28, 2024 · 0 comments · May be fixed by #5

Comments

@ivanovmg
Copy link

ivanovmg commented Dec 28, 2024 •
edited
Loading

I noticed than in consumer.py there are duplicate JSON deserialization operation via json.loads.
First time it happens in _is_json function and then repeats if it is indeed convertible to dict.
It seems reasonable to inline _is_json to avoid duplicate operations.

References:
@ivanovmg ivanovmg linked a pull request Dec 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inline _is_json to avoid duplicate deserialization ivanovmg/fastapi-kafka
1 participant
@ivanovmg