Add files via upload #1
Conversation
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| - name: Start my service | |||
There was a problem hiding this comment.
Task name should be appropriate
| service: | ||
| name: "{{ item }}" | ||
| state: started | ||
| loop: "{{ tool }}" |
There was a problem hiding this comment.
no need of loop, user service name directly
There was a problem hiding this comment.
Add details related with role info
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| - name: jinja2 template configuration | |||
There was a problem hiding this comment.
Naming is according to task and should be like
Configure Kibana
| update_cache: yes | ||
| when: ansible_os_family == 'Debian' | ||
|
|
||
| - name: dependencies are installing. (ubuntu) |
There was a problem hiding this comment.
Task naming should be proper
Install service dependecies
| url: https://artifacts.elastic.co/GPG-KEY-elasticsearch | ||
| state: present | ||
| validate_certs: yes | ||
| keyring: /usr/share/keyrings/elasticsearch-keyring.gpg |
|
|
||
| - name: adding repository (ubuntu) | ||
| apt_repository: | ||
| repo: 'deb [signed-by=/usr/share/keyrings/elasticsearch-keyring.gpg] https://artifacts.elastic.co/packages/8.x/apt stable main' |
There was a problem hiding this comment.
use variables and should not stick with a specific version
| - name: installing kibana (ubuntu) | ||
| apt: | ||
| update_cache: yes | ||
| name: "{{ tool }}" |
There was a problem hiding this comment.
no need to use variable here as this role is related with kibana only
| when: ansible_os_family == 'Debian' | ||
| notify: Start my service | ||
|
|
||
| - name: Adding GPG key (Red Hat) |
There was a problem hiding this comment.
split tasks into different file specific to host OS family
There was a problem hiding this comment.
If change required at one or two line then use lineinfile not template
Also no need of including complete default file
Please review kibana role