Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2560 - level column to numeric #2564

Merged
merged 2 commits into from
Feb 2, 2025

Conversation

elarlang
Copy link
Collaborator

@elarlang elarlang commented Feb 2, 2025

This Pull Request relates to issue #2560

@elarlang elarlang enabled auto-merge (rebase) February 2, 2025 10:37
@tghosth tghosth disabled auto-merge February 2, 2025 17:39
@tghosth tghosth marked this pull request as draft February 2, 2025 17:40
@tghosth
Copy link
Collaborator

tghosth commented Feb 2, 2025

This is a massive change so I want to mark it as draft until we are definitely ready to merge, main thing to do now is fix the output scripts. I'll try and get it done as soon as possible

@elarlang
Copy link
Collaborator Author

elarlang commented Feb 2, 2025

This is an artificial slow-down. It requires to be merged in fast or it causes merge conflicts to any requirement changes.

Who needs those output scripts for new content at the moment? We are going to change the format and the structure many times - this is no point to even develop those before structure is stable and RC1 is ready.

For old content - just keep old version of scripts for old content.

@tghosth
Copy link
Collaborator

tghosth commented Feb 2, 2025

It's cleaner to keep everything working, we don't have any open pull requests on the main chapters at the moment. Let's try and commit to get this merged by the end of Tuesday.

@tghosth tghosth marked this pull request as ready for review February 2, 2025 20:02
@tghosth
Copy link
Collaborator

tghosth commented Feb 2, 2025

The jedi are gonna feel this one...

@tghosth tghosth merged commit 6e78be7 into OWASP:master Feb 2, 2025
6 checks passed
@elarlang elarlang deleted the asvs-2560-levels-to-numeric branch February 3, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants