Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ios demos build #3126

Merged
merged 9 commits into from
Jan 22, 2025
+23 −9
Merged

Fix ios demos build #3126

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5db1b44
Enhance iOS build workflow with debugging step and path corrections
cpholguera Jan 22, 2025
bf492b3
Temporarily remove branch and path filters from iOS demo build workflow
cpholguera Jan 22, 2025
6a7f1ba
Fix entitlements path in iOS demo build workflow
cpholguera Jan 22, 2025
446a7f8
Update IPA output naming in iOS demo build workflow
cpholguera Jan 22, 2025
30006ef
Fix IPA naming in iOS build workflow to ensure correct file paths
cpholguera Jan 22, 2025
2b4dfd8
Fix output path for IPA files in iOS demo build workflow
cpholguera Jan 22, 2025
ef5bb79
Fix output path and variable references in iOS demo build workflow
cpholguera Jan 22, 2025
ffcce94
Improve IPA file path handling and add debug output for IPA existence…
cpholguera Jan 22, 2025
0b0631c
Add branch filter for pull requests in iOS demo build workflow
cpholguera Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions .github/workflows/build-ios-demos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ on:
- master
paths:
- 'demos/**'

jobs:
generate-matrix:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -52,9 +51,13 @@ jobs:
- name: Clone MASTestApp-iOS repository
run: git clone https://github.com/cpholguera/MASTestApp-iOS.git

- name: Debug repository contents
run: ls -R

- name: Install dependencies
run: |
brew install ldid cocoapods
cd MASTestApp-iOS || exit
pod install --repo-update || true

- name: Replace files and prepare build
Expand All @@ -79,15 +82,17 @@ jobs:

- name: Set Default Scheme
run: |
cd MASTestApp-iOS || exit
scheme_list=$(xcodebuild -list -json | tr -d "\n")
default=$(echo $scheme_list | ruby -e "require 'json'; puts JSON.parse(STDIN.gets)['project']['targets'][0]")
echo "DEFAULT_SCHEME=$default" >> $GITHUB_ENV
echo "DEFAULT_SCHEME=$default" >> "$GITHUB_ENV"
echo "Using default scheme: $default"

- name: Build the app (unsigned)
run: |
cd MASTestApp-iOS || exit
xcodebuild archive \
-project "MASTestApp-iOS/MASTestApp.xcodeproj" \
-project "MASTestApp.xcodeproj" \
-scheme "$DEFAULT_SCHEME" \
-archivePath "$GITHUB_WORKSPACE/build/MASTestApp.xcarchive" \
-configuration Release \
Expand All @@ -97,7 +102,7 @@ jobs:

- name: Add Entitlements
run: |
ldid -Sentitlements.plist "$GITHUB_WORKSPACE/build/MASTestApp.xcarchive/Products/Applications/MASTestApp.app/MASTestApp"
ldid -SMASTestApp-iOS/entitlements.plist "$GITHUB_WORKSPACE/build/MASTestApp.xcarchive/Products/Applications/MASTestApp.app/MASTestApp"

- name: Create IPA manually
run: |
Expand All @@ -106,19 +111,28 @@ jobs:
zip -r9q MASTestApp.zip Payload
mv MASTestApp.zip MASTestApp.ipa
mkdir -p "$GITHUB_WORKSPACE/output"
mv MASTestApp.ipa "$GITHUB_WORKSPACE/output/MASTestApp-unsigned.ipa"
mv MASTestApp.ipa "$GITHUB_WORKSPACE/output/$(basename "${{ matrix.demo }}").ipa"

- name: Set IPA name variable
id: set_ipa_name
run: echo "IPA_NAME=$(basename ${{ matrix.demo }}).ipa" >> $GITHUB_ENV
run: echo "IPA_NAME=$(basename "${{ matrix.demo }}").ipa" >> $GITHUB_ENV

- name: List generated IPA
run: |
echo "Listing generated IPA in output directory:"
ls -l "$GITHUB_WORKSPACE/output/${{ env.IPA_NAME }}" || echo "No IPA found."
ls -l output/

- name: Debug IPA Path Before Upload
run: |
if [ -f "output/${{ env.IPA_NAME }}" ]; then
echo "IPA file exists and ready for upload: output/${{ env.IPA_NAME }}"
else
echo "ERROR: IPA file not found at output/${{ env.IPA_NAME }}"
exit 1
fi

- name: Upload IPA
uses: actions/upload-artifact@v4
with:
name: ${{ env.IPA_NAME }}
path: "$GITHUB_WORKSPACE/output/${{ env.IPA_NAME }}"
name: "${{ env.IPA_NAME }}"
path: "output/${{ env.IPA_NAME }}"
Loading