-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleanups #1614
Code cleanups #1614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I don't have any suggested changes. The C code change in codegenerator file is a bit of a mystery to me at the moment, feel free to go ahead if you're confident.
Also, what is the role of the SampleP kernel? Something to to with triggering an update? If the tmp variable name itself isn't important (but the assignment is), could we use _
as a varname instead in line with python convention?
@erikvansebille do you know the role of the assignment in |
Yep, it's to trigger the sampling of the P-field, and therefore the assignment of |
This PR combines some code cleanups and minor bug fixes that I stumbled upon while developing #1612