Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIT-2774] Enable external-signer for batch-poster with DA #2669

Merged
merged 10 commits into from
Sep 26, 2024
Merged

[NIT-2774] Enable external-signer for batch-poster with DA #2669

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ae1ceae
Enable external-signer for batch-poster with DA
gligneul Sep 12, 2024
c041e12
Merge branch 'master' into gligneul/external-signer-for-anytrust
gligneul Sep 12, 2024
cf1bffb
Merge branch 'master' into gligneul/external-signer-for-anytrust
gligneul Sep 13, 2024
996758f
Merge branch 'master' into gligneul/external-signer-for-anytrust
gligneul Sep 13, 2024
2df5479
Merge branch 'master' into gligneul/external-signer-for-anytrust
gligneul Sep 16, 2024
943af67
Merge branch 'master' into gligneul/external-signer-for-anytrust
gligneul Sep 16, 2024
2236d3c
Merge branch 'master' into gligneul/external-signer-for-anytrust
gligneul Sep 17, 2024
3f90077
Merge branch 'master' into gligneul/external-signer-for-anytrust
amsanghi Sep 23, 2024
29b294f
Merge branch 'master' into gligneul/external-signer-for-anytrust
gligneul Sep 25, 2024
cc3a52a
Merge branch 'master' into gligneul/external-signer-for-anytrust
PlasmaPower Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/nitro/nitro.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ func mainImpl() int {
// If sequencer and signing is enabled or batchposter is enabled without
// external signing sequencer will need a key.
sequencerNeedsKey := (nodeConfig.Node.Sequencer && !nodeConfig.Node.Feed.Output.DisableSigning) ||
(nodeConfig.Node.BatchPoster.Enable && nodeConfig.Node.BatchPoster.DataPoster.ExternalSigner.URL == "")
(nodeConfig.Node.BatchPoster.Enable && (nodeConfig.Node.BatchPoster.DataPoster.ExternalSigner.URL == "" || nodeConfig.Node.DataAvailability.Enable))
validatorNeedsKey := nodeConfig.Node.Staker.OnlyCreateWalletContract ||
(nodeConfig.Node.Staker.Enable && !strings.EqualFold(nodeConfig.Node.Staker.Strategy, "watchtower") && nodeConfig.Node.Staker.DataPoster.ExternalSigner.URL == "")

Expand Down
Loading