Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfit update to reflect recent requirements #11

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

Ofosu-Osei
Copy link
Owner

No description provided.

@Ofosu-Osei Ofosu-Osei requested a review from nickeubank June 19, 2024 19:34
@nickeubank
Copy link
Collaborator

THANKS! Comments soon

@nickeubank
Copy link
Collaborator

Does this address #1? Looks like you moved to regular confidence intervals (cool!), but it still doesn't work as something you pass into an .add() method (e.g., .add(so.Lines, sor.Lowess()) or .add(so.Lines, sor.PolyFitWithCI()) does it?

@Ofosu-Osei
Copy link
Owner Author

Does this address #1? Looks like you moved to regular confidence intervals (cool!), but it still doesn't work as something you pass into an .add() method (e.g., .add(so.Lines, sor.Lowess()) or .add(so.Lines, sor.PolyFitWithCI()) does it?

You know what, I think I misinterpreted the example you provided that returned a plot. So I thought you wanted the recipes to be called independently with arguments. I can fix this by going back to the original implementation style. Thanks!

@nickeubank
Copy link
Collaborator

That's poor communication on my part — the example you link was a "throw-together" that did what I wanted in terms of output, but was in no way integrated into the modular/composable framework of seaborn.objects I want to move towards.

Also: Starting July 1 you can start billing time on this. Just let me know about every two weeks how much your billing (and you may bill whatever you've put in earlier this summer).

@Ofosu-Osei
Copy link
Owner Author

Message acknowledged, I'll work on it as soon as possible.

@Ofosu-Osei Ofosu-Osei merged commit ba7b5f4 into main Jun 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants