Lowess and PolyFitWithCI updates #12
Conversation
| @@ -81,38 +79,21 @@ def test_line_label(sample_data, cleanup_files): | |||
| ```python | |||
| import seaborn_objets_recipes as sor | |||
| @@ -37,7 +36,7 @@ Please refer to the [testing file](https://github.com/Ofosu-Osei/seaborn_objects | |||
| ```python | |||
| import seaborn_objets_recipes as sor | |||
| @@ -125,27 +106,23 @@ def test_lowess(): | |||
| ```python | |||
| import seaborn_objets_recipes as sor | |||
| .add( | ||
| sor.LineLabel(offset=5), | ||
| so.Agg(), | ||
| sor.Rolling(window_type="gaussian", window_kwargs={"std": 2}), | ||
| rolling, | ||
| legend=False, | ||
| ) | ||
| .add(so.Band(), so.Est(errorbar="se"), legend=False) |
There was a problem hiding this comment.
I don't see a band in the figure below — is there supposed to be one, and if not, what's this line doing?
There was a problem hiding this comment.
I agree, I think I took it out in one of my actual testing but forgot it here. I'll take it out.
|
I'd suggest taking all the code snippets in the README and make sure they run — I think there are a few issues there? |
|
Other than that I think we're set! I'll make an issue with next steps |
So there is a reference to a complete testing processes at the beginning of the usage section. However, I can replicate the complete code here if necessary. |
|
Users -- some of whom won't have a good sense of testing -- will want to see examples so I think what's there is good -- you just wanna make sure it works |
This is an initial push of the current update for your review. I'll deploy to pypi if no changes are needed for now.