Improve logging and refactor AST utilities #109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had planned these for some time:
SU.ast
in SILE 0.15-develop and silex.ast provides our compatibility layer for these with SILE 0.14.x, so it an obvious change for the future.The latter greatly improves debugging... Now we get line and colum, and stack details:
Or with
-t
(snippet):On the first parsing warning, we don't get line and column details ('cause jgm/djot.lua#14), but at least we can extract and show some bits of text to help with finding and fixing them.