fix: Djot user-defined pseudo-symbols nesting issue #141
+77
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omikhleia
force-pushed
the
fix-shallow-copy-issue
branch
from
494ab2f to
8244a20
Compare
Omikhleia
force-pushed
the
fix-shallow-copy-issue
branch
from
8244a20 to
daeae9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue as found via the resilient manual revamping Omikhleia/resilient.sile#122
(whatever unicode symbol is U+xxxx)
We are modifying by side effect the options, and an error occurs on the second occurrence.
I don't like shallow copying lists for no obvious reasons, but there seems to be other cases that could be affected too, and I lack time for investigating them...