-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support more rough features #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omikhleia
commented
Dec 16, 2023
Omikhleia
force-pushed
the
feat-more-roughjs-port
branch
from
December 16, 2023 17:42
75f390c
to
d59d2d1
Compare
Omikhleia
force-pushed
the
feat-more-roughjs-port
branch
4 times, most recently
from
January 13, 2024 23:23
8b812f2
to
1ab7e1e
Compare
Refactoring the rough-lua port and adding lots of missing bits.
Omikhleia
force-pushed
the
feat-more-roughjs-port
branch
from
January 14, 2024 18:10
1ab7e1e
to
8c53b80
Compare
These are not needed (yet) in our framebox use, but let's have them in an "untested" folder. This will help to get started if we later decide to extract the port as a separate Lua rocks.
Omikhleia
force-pushed
the
feat-more-roughjs-port
branch
from
January 14, 2024 18:31
8c53b80
to
ae14353
Compare
Things should be ready for possibly extracting |
Tested, as used by framebox:
Quickly tested with ad-hoc temporary hacks in framebox:
Untested:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More features from roughjs ported to Lua and more options to
\roughbox
:I started this some time ago and thought I lost it. Just recovered it, so let's save it in a branch.
Unfinished, with FIXME comments -- And perhaps regressions / mistakes.
I guess the idea was eventually to extract the rough-lua part as a standalone rock.
Note:
Partial port only for SVG paths and curves on points, they use two additional modules (
points-on-curve
,path-data-parser
) which I have ported, but not tested.So I left them outThe feature is not needed in my current use case... Let's have them in an "untested" folder for now.