Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support more rough features #15

Merged
merged 4 commits into from
Jan 14, 2024
Merged

feat: Support more rough features #15

merged 4 commits into from
Jan 14, 2024

Conversation

Omikhleia
Copy link
Owner

@Omikhleia Omikhleia commented Dec 16, 2023

More features from roughjs ported to Lua and more options to \roughbox:

I started this some time ago and thought I lost it. Just recovered it, so let's save it in a branch.

Unfinished, with FIXME comments -- And perhaps regressions / mistakes.
I guess the idea was eventually to extract the rough-lua part as a standalone rock.

  • Initial recovered version (refactored + many fillers)
  • Missing filler zigzag-line
  • JS shims refactor
  • Missing code for arcs, ellipses, circles + test
  • Missing code for SVG paths + curves on points = partial, see note
  • Clean-up

Note:
Partial port only for SVG paths and curves on points, they use two additional modules (points-on-curve, path-data-parser) which I have ported, but not tested. So I left them out
The feature is not needed in my current use case... Let's have them in an "untested" folder for now.

@Omikhleia Omikhleia added the enhancement New feature or request label Dec 16, 2023
@Omikhleia
Copy link
Owner Author

Seems it was quite working --

image

So surely finishing and reviewing the port would be cool.

@Omikhleia Omikhleia added this to the 3.0 milestone Dec 16, 2023
@Omikhleia Omikhleia force-pushed the feat-more-roughjs-port branch from 75f390c to d59d2d1 Compare December 16, 2023 17:42
@Omikhleia Omikhleia force-pushed the feat-more-roughjs-port branch 4 times, most recently from 8b812f2 to 1ab7e1e Compare January 13, 2024 23:23
@Omikhleia Omikhleia force-pushed the feat-more-roughjs-port branch from 1ab7e1e to 8c53b80 Compare January 14, 2024 18:10
These are not needed (yet) in our framebox use, but let's have
them in an "untested" folder. This will help to get started if we
later decide to extract the port as a separate Lua rocks.
@Omikhleia Omikhleia force-pushed the feat-more-roughjs-port branch from 8c53b80 to ae14353 Compare January 14, 2024 18:31
@Omikhleia
Copy link
Owner Author

Things should be ready for possibly extracting prng-prirogin and rough-lua as separate Lua rocks.
No doing it here yet, though -- it's easier for now to have everything at hand if I need to make last minute adjustments.

@Omikhleia
Copy link
Owner Author

Omikhleia commented Jan 14, 2024

Tested, as used by framebox:

  • rectangle
  • line
  • fillers

Quickly tested with ad-hoc temporary hacks in framebox:

  • ellipse
  • circle
  • arc

Untested:

  • curve (from points)
  • path (from SVG)
  • the dependencies of these (= 2 untested module folders)

@Omikhleia Omikhleia merged commit 42282e8 into main Jan 14, 2024
2 checks passed
@Omikhleia Omikhleia deleted the feat-more-roughjs-port branch January 14, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant