Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua 5.1 minimum compatibility #7

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Lua 5.1 minimum compatibility #7

merged 1 commit into from
Dec 28, 2023

Conversation

Omikhleia
Copy link
Owner

See Omikhleia/resilient.sile#70

silex/fixes.lua:174:23: accessing undefined field searchpath of global package

IIRC, that line was copied from SILE.

@Omikhleia Omikhleia added this to the 0.3.1 milestone Dec 8, 2023
@alerque
Copy link
Contributor

alerque commented Dec 8, 2023

We appear to be running luacheck wrong upstream in SILE because we have std = "max" instead of std = "min". I'll look into that now and it may be that since we're loading compat patches we can actually use "max", but we should clarify that. I'll look into it.

@alerque
Copy link
Contributor

alerque commented Dec 8, 2023

See Omikhleia/resilient.sile#70

silex/fixes.lua:174:23: accessing undefined field searchpath of global package

IIRC, that line was copied from SILE.

This lint can be ignored. We were not throwing it on SILE because we were configured correctly, but we are also loading a compat library that adds some Lua 5.3 stuff into Lua 5.1, and this searchpath is one of them.

I'm trying to figure out how to best configure luacheck now.

@alerque
Copy link
Contributor

alerque commented Dec 8, 2023

I just fixed this in luacheck so that --std min+sile should now allow the use of package.searchpath() since we patch it into Lua 5.1. It will be in a new version of LuaCheck shortly.

@alerque
Copy link
Contributor

alerque commented Dec 8, 2023

Simply re-running CI should fix this now since the GihHub Action has been updated.

@Omikhleia Omikhleia merged commit e8ba002 into main Dec 28, 2023
2 checks passed
@Omikhleia Omikhleia deleted the fix-lua51-compat branch January 27, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants