Integration Groundwork #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TripPlannerService needs to be moved away from its current singleton model for easier integration into other apps and easier testing. The first step towards this is by exposing an initializer that lets a caller instantiate the service with all of its dependencies.
This change will help us integrate into other apps and make it much, much easier to unit test OTPKit
It's easier to type, more closely reflects its purpose, and matches its class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors parts of the OTPKit codebase to make integration into another app and testing both much easier. The key changes here are:
LocationManagerServicetoTripPlannerServiceto better reflect its purpose