refactor swaps #309
Open
refactor swaps #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xosama
commented
Feb 3, 2023
| return findBestPath(this._getAmountIn, payload, amountOut); | ||
| } | ||
|
|
||
| function findBestPath( |
There was a problem hiding this comment.
pay attention to this func @Drypto13
0xosama
commented
Feb 3, 2023
| function dexAmountIn(bytes memory payload, uint256 amountOut) public view returns (uint256 amountIn, address midToken) { | ||
| (amountIn, midToken) = findBestPath(this._getAmountIn, payload, amountOut); | ||
|
|
||
| if (amountIn == type(uint256).max) { |
There was a problem hiding this comment.
why do we set this here? there is no similar construct in getAmountOut
0xosama
commented
Feb 3, 2023
| amountIn := mload(add(data, 96)) // first amount value in array | ||
| } | ||
| } | ||
| if (amountIn == 0) { |
There was a problem hiding this comment.
why do we set this here? there is no similar construct in getAmountOut.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.