chore: replace node crypto with browserify module #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to webpack v5 not including all polyfills by default, downstream websites/libraries consuming @govtechsg/open-attestation would lead to build errors if one uses create-react-app to build and construct their site.
This is highlighted in this issue:
#239
This chore replaces the current way we are using the
randomBytesfunction from node crypto and makes it isomorphic via the browserify module.In the first place is this something the lib should be concerned about? in the issue above, i told the guy to handle the polyfills at the application level.