feat: allow both OA and W3C VCs to be digested or signed #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HJunyuan
changed the title
* fix: make types more granular * fix: use new types, assert that vc is proofless * refactor: bring w3cVc schema definitions tgt * fix: use new types * fix: update references to guards and types * fix: update references to guards and types * fix: tests * refactor: rename wrap to digest * refactor: already checking for proofless data model error in digest * fix: naming * refactor: reference proofless schema, custom err msg * fix: builder error shd have digest and sign errors * fix: tests * refactor: oaDigested should mean only digested, and not include signed documents * refactor: useless alias
|
🎉 This PR is included in version 6.10.0-beta.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR will introduce breaking changes to OA v4 (which is currently in beta).
signVc()will automatically digest before performing signing. As such, digest and sign are now separate processessignVc()will not re-sign ifproofobject is already defineddigestVc()is left available for use with Ethereum issuancesrc/index.ts)documenttovc