Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI for get started example #13

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Update CI for get started example #13

merged 1 commit into from
Feb 13, 2024

Conversation

JonatanAntoni
Copy link
Contributor

  • Fix typos and warnings in README
  • Enable dependabot for workflows
  • Add Clang linker script
  • Build/run example in workflow for all compilers

@JonatanAntoni JonatanAntoni requested a review from jkrech February 13, 2024 10:49
@JonatanAntoni JonatanAntoni force-pushed the actions branch 5 times, most recently from 9d9cef0 to 8606b7a Compare February 13, 2024 11:09
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@JonatanAntoni JonatanAntoni force-pushed the actions branch 3 times, most recently from 2a5cc2e to d1871c8 Compare February 13, 2024 11:21
- Fix typos and warnings in README
- Enable dependabot for workflows
- Add Clang linker script
- Build/run example in workflow for all compilers
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I am wondering though, whether we should reference the documentation in cmsis-toolbox to duplicate the setup using vcpkg and ENVIRONMENT VARIABLES.
Having this is a single place makes it easier to maintain.

https://github.com/Open-CMSIS-Pack/cmsis-toolbox/blob/main/docs/installation.md

@JonatanAntoni JonatanAntoni merged commit f7993b6 into main Feb 13, 2024
5 checks passed
@JonatanAntoni JonatanAntoni deleted the actions branch February 13, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants