feat: rework error codes #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intro reworded for clarity
Signed-off-by: Philipp Bolte <[email protected]>
|
From my perspective, changes from #59 can be merged into this PR. @bluesteens |
31 tasks
This was referenced Aug 3, 2023
Closed
Signed-off-by: Philipp Bolte <[email protected]>
bluesteens
reviewed
Aug 8, 2023
bluesteens
reviewed
Aug 8, 2023
bluesteens
reviewed
Aug 9, 2023
Signed-off-by: Philipp Bolte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to extend and fix issues with the current set of error codes. Due to issues in https://open-credentialing-initiative.github.io/schemas/specification/latest/#verifiable-presentation-metadata (off-spec with W3C VC – will provide more context in another PR I will link here), the error codes have to be adjusted to take into account the correct (or incorrect) usage of the JWT VP fields. I also added some more error codes to cover issues around DID resolution, schema checks, and more.