Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for invalid inject_tlm states, rescue bad values #1866

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Conversation

jmthomas
Copy link
Member

closes #1857

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.38%. Comparing base (cbbd238) to head (8fa82fb).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
openc3/lib/openc3/api/tlm_api.rb 83.33% 1 Missing ⚠️
...lib/openc3/microservices/interface_decom_common.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1866      +/-   ##
==========================================
- Coverage   79.41%   79.38%   -0.03%     
==========================================
  Files         523      523              
  Lines       40888    40899      +11     
==========================================
- Hits        32470    32469       -1     
- Misses       8418     8430      +12     
Flag Coverage Δ
python 83.93% <ø> (-0.07%) ⬇️
ruby-api 48.42% <ø> (ø)
ruby-backend 82.51% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@jmthomas jmthomas merged commit 42d3523 into main Jan 29, 2025
30 checks passed
@jmthomas jmthomas deleted the inject branch January 29, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper inject_tlm values "lock up" the CmdTlmServer interface
2 participants