Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import-map-overrides and vuetify-labs #1869

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Update import-map-overrides and vuetify-labs #1869

merged 3 commits into from
Jan 30, 2025

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Jan 29, 2025

I forgot to re-run the package_audit script once I changed some of those top level libraries. Not sure how all the front-end built with the old libraries.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.40%. Comparing base (c922d8d) to head (f75ab2a).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
openc3-cosmos-cmd-tlm-api/config/application.rb 75.00% 1 Missing ⚠️
...nc3-cosmos-script-runner-api/config/application.rb 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1869      +/-   ##
==========================================
- Coverage   79.40%   79.40%   -0.01%     
==========================================
  Files         523      523              
  Lines       40899    40905       +6     
==========================================
+ Hits        32477    32479       +2     
- Misses       8422     8426       +4     
Flag Coverage Δ
python 83.97% <ø> (-0.02%) ⬇️
ruby-api 48.45% <75.00%> (+0.02%) ⬆️
ruby-backend 82.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas
Copy link
Member Author

jmthomas commented Jan 30, 2025

I had to revert Vuetify because the latest releases were not being mirrored to cdnjs. 3.7.6 was the latest:
Screenshot 2025-01-29 at 5 08 30 PM

@jmthomas jmthomas merged commit db591b6 into main Jan 30, 2025
30 checks passed
@jmthomas jmthomas deleted the dependencies branch January 30, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants