Feature sram #20
Merged
Feature sram #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 19, 2024
quartje
requested changes
Nov 29, 2024
There was a problem hiding this comment.
Welcome to the party!
Some remarks:
- Your entrypoint script is mounted in /opt/sbs/config. However, your Dockerfile of SBS uses /entrypoint.sh so this entrypoint is not used at all (or I am missing something)
- Would you be so kind to add a profile for SBS? Otherwise a docker compose up would bring up everything. No need to start SBS and redis when doing other development tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SRAM (SBS) container to devconf deploy
SURFscz/SRAM-deploy#550
SURFscz/SBS#1705