-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix initialisation of devconf core #30
Conversation
4d80f6c
to
b989625
Compare
@@ -55,16 +55,16 @@ while true; do | |||
# Use docker compose to start the environment but with the modified override file(s) | |||
echo -e "\nStarting the ${MODE} environment with the following command:\n" | |||
|
|||
echo -e "docker compose --profile php -f docker-compose.yml "${docker_compose_args[@]}" "${extra_compose_args}" up -d "${@:$number_of_dev_envs}"\n" | |||
docker compose --profile php -f docker-compose.yml ${docker_compose_args[@]} ${extra_compose_args} up -d "${@:$number_of_dev_envs}" | |||
echo -e "docker compose --profile oidc -f docker-compose.yml "${docker_compose_args[@]}" "${extra_compose_args}" up -d "${@:$number_of_dev_envs}"\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@quartje is it possible to do this in order to be able to push from Manage to EB and don't get an exception in Manage?
Or is this the wrong way to achieve this?
And should I for example add php
to the docker-compose services that already have oidc
as proffile? Becuase I don't fully understand why I need oidc
in order to push from Manage to Engine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manage pushes to both oidc and eb. This would fix that issue.
In an ideal world, Manage would be configured dynamically (so --profile php would config manage only to push to eb, not to oidc).
@@ -55,16 +55,16 @@ while true; do | |||
# Use docker compose to start the environment but with the modified override file(s) | |||
echo -e "\nStarting the ${MODE} environment with the following command:\n" | |||
|
|||
echo -e "docker compose --profile php -f docker-compose.yml "${docker_compose_args[@]}" "${extra_compose_args}" up -d "${@:$number_of_dev_envs}"\n" | |||
docker compose --profile php -f docker-compose.yml ${docker_compose_args[@]} ${extra_compose_args} up -d "${@:$number_of_dev_envs}" | |||
echo -e "docker compose --profile oidc -f docker-compose.yml "${docker_compose_args[@]}" "${extra_compose_args}" up -d "${@:$number_of_dev_envs}"\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manage pushes to both oidc and eb. This would fix that issue.
In an ideal world, Manage would be configured dynamically (so --profile php would config manage only to push to eb, not to oidc).
No description provided.