Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialisation of devconf core #30

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

pablothedude
Copy link
Contributor

No description provided.

@pablothedude pablothedude force-pushed the bugfix/fix-initial-initialisation branch from 4d80f6c to b989625 Compare January 17, 2025 15:50
@@ -55,16 +55,16 @@ while true; do
# Use docker compose to start the environment but with the modified override file(s)
echo -e "\nStarting the ${MODE} environment with the following command:\n"

echo -e "docker compose --profile php -f docker-compose.yml "${docker_compose_args[@]}" "${extra_compose_args}" up -d "${@:$number_of_dev_envs}"\n"
docker compose --profile php -f docker-compose.yml ${docker_compose_args[@]} ${extra_compose_args} up -d "${@:$number_of_dev_envs}"
echo -e "docker compose --profile oidc -f docker-compose.yml "${docker_compose_args[@]}" "${extra_compose_args}" up -d "${@:$number_of_dev_envs}"\n"
Copy link
Contributor Author

@pablothedude pablothedude Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quartje is it possible to do this in order to be able to push from Manage to EB and don't get an exception in Manage?
Or is this the wrong way to achieve this?
And should I for example add php to the docker-compose services that already have oidc as proffile? Becuase I don't fully understand why I need oidc in order to push from Manage to Engine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manage pushes to both oidc and eb. This would fix that issue.
In an ideal world, Manage would be configured dynamically (so --profile php would config manage only to push to eb, not to oidc).

@@ -55,16 +55,16 @@ while true; do
# Use docker compose to start the environment but with the modified override file(s)
echo -e "\nStarting the ${MODE} environment with the following command:\n"

echo -e "docker compose --profile php -f docker-compose.yml "${docker_compose_args[@]}" "${extra_compose_args}" up -d "${@:$number_of_dev_envs}"\n"
docker compose --profile php -f docker-compose.yml ${docker_compose_args[@]} ${extra_compose_args} up -d "${@:$number_of_dev_envs}"
echo -e "docker compose --profile oidc -f docker-compose.yml "${docker_compose_args[@]}" "${extra_compose_args}" up -d "${@:$number_of_dev_envs}"\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manage pushes to both oidc and eb. This would fix that issue.
In an ideal world, Manage would be configured dynamically (so --profile php would config manage only to push to eb, not to oidc).

@pablothedude pablothedude merged commit 98e9f7c into main Jan 20, 2025
2 checks passed
@pablothedude pablothedude deleted the bugfix/fix-initial-initialisation branch January 20, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants