Restore the Stepup E2E behat tests #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quartje
force-pushed
the
feature/behat_tests
branch
3 times, most recently
from
b0e1413 to
9685ce9
Compare
Some modifications have been been made. The url stepup.example.com has been changed everywhere. Also overrides have been removed.
STEPUP_VERSION can be used to pull the correct tag for the docker images (either prod or test). APP_ENV can be used to set the APP_ENV in the container. If these vars are not present in a .env file the default is "prod"
…s STEPUP_APP=test then it starts the requested dev containers in smoketest mode
And while at it, increase its test coverage
MKodde
force-pushed
the
feature/behat_tests
branch
from
2f09d61 to
bfd7c7d
Compare
1. Add verbosity by showing which apps are started in dev mode 2. Allow option to run the script in the background
pmeulen
reviewed
Feb 7, 2024
stepup/start-dev-env.sh
Outdated
| done | ||
|
|
||
| # Because numbering is off by one, reference the next arg | ||
| let number_of_dev_envs=number_of_dev_envs+1 | ||
| # Read the generated env file with the apps and their code paths |
There was a problem hiding this comment.
I think you can simplefy the argument processing using shift (https://tldp.org/LDP/Bash-Beginners-Guide/html/sect_09_07.html)
See e.g. https://github.com/OpenConext/Stepup-Build/blob/master/stepup-build.sh
There was a problem hiding this comment.
@pmeulen I see how this could work, I'm going to attempt to utilize that method. I'll be sure to check in with you if I get stranded.
After the fixture was updated, it now includes 3 identities
To enable them one by one once they are fixed. This allows me to keep all tests green and not having to run hundreds of failing tests
notable changes: events were updated to set default language to en_GB for the identities.
Awaiting the repair of the SSP test SP/IdP
The Event stream needed some tweaking (mainly to get my first name out of the identities ;) )
No additional action was required to enable the test except for setting the token identifier for the yubikey
No changes required to get it up and running again.
Support was added for demo gssps as a token type that can be vetted The test was somewhat modified to reflect te users present in our fixtures but in basis the test remained the same
In order to make tests green, the default institution config was changed slightly
Both features have been enabled. Enabling gssp (demo_gssp) authn in the process. The removed stepup. example.org institution was removed from the whitelist
MKodde
force-pushed
the
feature/behat_tests
branch
8 times, most recently
from
60fce82 to
1f654a4
Compare
- No longer create /var/www/html/public: This is done upstream - Use the latest versions of GH actions - No longer build the image at every push.
MKodde
force-pushed
the
feature/behat_tests
branch
8 times, most recently
from
2b2b166 to
2013d82
Compare
Make some of the outputted text more explicit. This is done by putting more emphasis when running the suite in test mode (then a green bold text is displayed stating you are running test-mode) But also by adding the context (dev|test) to other debug statements. Finally, the script is more defensive, and checks file existence before sourcing their contents. Preventing file not found errors
Adding functional test documentation.
MKodde
force-pushed
the
feature/behat_tests
branch
3 times, most recently
from
a427274 to
d76935a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.