Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gather - show all failed edges in error message #1095

Merged
merged 18 commits into from
Jan 30, 2025
Merged

Conversation

atravitz
Copy link
Contributor

@atravitz atravitz commented Jan 24, 2025

Closes #1101

Checklist

  • Added a news entry

Developers certificate of origin

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.82%. Comparing base (870463b) to head (78ba28e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
- Coverage   93.56%   91.82%   -1.74%     
==========================================
  Files         137      137              
  Lines       10105    10096       -9     
==========================================
- Hits         9455     9271     -184     
- Misses        650      825     +175     
Flag Coverage Δ
fast-tests 91.82% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atravitz atravitz self-assigned this Jan 27, 2025
@atravitz atravitz force-pushed the output_all_failed_edges branch 2 times, most recently from 74e558b to bfe911e Compare January 27, 2025 20:24
@atravitz atravitz changed the title [WIP] Output all failed edges gather - show all failed edges in error message Jan 27, 2025
@atravitz atravitz marked this pull request as ready for review January 27, 2025 21:03
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but the error message seems like it might be a bit too unweildy.

Ideally we want something that's easy to parse for edges rather than a lot of text around each printed line.

openfecli/commands/gather.py Outdated Show resolved Hide resolved
@atravitz atravitz force-pushed the output_all_failed_edges branch from fec49d6 to cae75d1 Compare January 29, 2025 00:10
@atravitz atravitz force-pushed the output_all_failed_edges branch from cae75d1 to f6c9ef8 Compare January 29, 2025 19:02
Copy link
Collaborator

@jthorton jthorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One not blocking suggestion for info on restarting, otherwise this is great!

Copy link

No API break detected ✅

@atravitz atravitz merged commit 0141744 into main Jan 30, 2025
12 checks passed
@atravitz atravitz deleted the output_all_failed_edges branch January 30, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gather - show all failed edges in error message #1095
3 participants