Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking tests from gufe updates #1107

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

atravitz
Copy link
Contributor

@atravitz atravitz commented Jan 30, 2025

gufe PRS OpenFreeEnergy/gufe#468 and OpenFreeEnergy/gufe#467 cause tests to break on the openfe side.

@jthorton - could you confirm that this change to the tyk2 output is what you expect?

Checklist

  • Added a news entry

Developers certificate of origin

@atravitz atravitz requested a review from jthorton January 30, 2025 20:59
@atravitz atravitz self-assigned this Jan 30, 2025
@atravitz atravitz marked this pull request as draft January 30, 2025 21:44
Copy link

No API break detected ✅

@jthorton
Copy link
Collaborator

@atravitz thanks for taking this, and yes I expect different edges for the tyk2 network now, let hope this is the last time we have to fix this for a while!

@atravitz atravitz added this to the v1.4.0 milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants