multiple server restart issue fix for maven #927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meter with true for ci.gradle
|
Application multi restart is reported in Maven, Gradle has task state check, which will not trigger recompile, unless there is any dependency change. https://docs.gradle.org/current/userguide/more_about_tasks.html |
Signed-off-by: Arun Venmany <[email protected]>
arunvenmany-ibm
changed the title
cherylking
requested changes
Jan 8, 2025
| @@ -387,6 +387,7 @@ class DevTask extends AbstractFeatureTask { | |||
| true /* useBuildRecompile */, true /* gradle */, pollingTest, container, containerfile, containerBuildContext, containerRunOpts, containerBuildTimeout, skipDefaultPorts, | |||
| null /* compileOptions not needed since useBuildRecompile is true */, keepTempContainerfile, mavenCacheLocation, projectModuleList /* multi module upstream projects */, | |||
| projectModuleList.size() > 0 /* recompileDependencies as true for multi module */, packagingType, buildFile, parentBuildGradle /* parent build files */, generateFeatures, null /* compileArtifactPaths */, null /* testArtifactPaths */, webResourceDirs /* webResources */ | |||
| ,Collections.emptyMap() /*ignored for gradle*/ | |||
There was a problem hiding this comment.
This PR would be unnecessary if you provided a constructor that did not take this new Map since it is not needed for Gradle. That constructor could then just turn around and call the other one passing an empty Map, but in ci.common instead of ci.gradle.
|
Closing PR after adding a new constructor in ci.common DevUtil() for ci.maven, hence common changes will not affect ci.gradle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding constructor parameter with emptymap for ci.gradle