Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git.properties file with build id #240

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scottkurz
Copy link
Member

@scottkurz scottkurz commented Nov 1, 2023

I copied this from StackOverflow somewhere. Should the git.properties really go right in the root or META-INF? I'm not even sure why I have the build-helper-maven-plugin and not just the other plugin. Leaving as a draft.

@cherylking
Copy link
Member

Is this going to play well with the maven-shade-plugin we are using to control what goes into the build artifact?

@scottkurz
Copy link
Member Author

Is this going to play well with the maven-shade-plugin we are using to control what goes into the build artifact?

I think it does, for now...the git.properties file still seems to appear in the final artifact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants