Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the Unused createMavenModule method #1206

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Removed the Unused createMavenModule method #1206

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a4a80c8
Changed the getModuleFilePath() method which is marked as @ApiStatus.…
anusreelakshmi934 Jan 2, 2025
b7cf827
Removed createMavenModule
anusreelakshmi934 Jan 7, 2025
288b7c3
Update BaseJakartaTest.java
anusreelakshmi934 Jan 7, 2025
67ae500
Removed unused createJavaModule
anusreelakshmi934 Jan 7, 2025
2b8a7f2
Update BaseJakartaTest.java
anusreelakshmi934 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions src/test/java/io/openliberty/tools/intellij/lsp4jakarta/it/core/BaseJakartaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,6 @@ protected void setUpFixtures() throws Exception {
LanguageLevelProjectExtension.getInstance(testFixture.getProject()).setLanguageLevel(LanguageLevel.JDK_1_6);
}

anusreelakshmi934 marked this conversation as resolved.
Show resolved Hide resolved
protected Module createJavaModule(final String name) throws Exception {
ModuleFixture moduleFixture = myProjectBuilder.addModule(JavaModuleFixtureBuilder.class).getFixture();
moduleFixture.setUp();
Module module = myProjectBuilder.addModule(JavaModuleFixtureBuilder.class).getFixture().getModule();
return module;
}

private static AtomicInteger counter = new AtomicInteger(0);

/**
Expand Down Expand Up @@ -106,23 +99,4 @@ protected Module createMavenModule(File projectDir) throws Exception {
return modules.get(modules.size() - 1);
}

/**
* Create a new module into the test project from existing in memory POM.
*
* @param name the new module name
* @param xml the project POM
* @return the created module
*/
protected Module createMavenModule(String name, String xml) throws Exception {
Module module = getTestFixture().getModule();
File moduleDir = new File(module.getModuleFilePath()).getParentFile();
VirtualFile pomFile = createPomFile(LocalFileSystem.getInstance().findFileByIoFile(moduleDir), xml);
importProjects(pomFile);
Module[] modules = ModuleManager.getInstance(getTestFixture().getProject()).getModules();
if (modules.length > 0) {
module = modules[modules.length - 1];
setupJdkForModule(module.getName());
}
return module;
}
}
Loading