Issue381 - Automated test case implementation - hover support for server.xml Liberty Server Feature #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| editor = await new EditorView().openEditor('server.xml') as TextEditor; | ||
|
|
||
| const hverExpectdOutcome = `'wrong' is not a valid value of union type 'booleanType'.`; | ||
| const testHverTarget = '<logging appsWriteJson = \"wrong\" />'; |
There was a problem hiding this comment.
Please move all the hardcoded strings to a constants file.
src/test/GradleSingleModLCLSTest.ts
Outdated
| await VSBrowser.instance.openResources(path.join(utils.getGradleProjectPath(), 'src', 'main', 'liberty', 'config2', 'server.xml')); | ||
|
|
||
| editor = await new EditorView().openEditor('server.xml') as TextEditor; | ||
| const stanzaSnipet = "<logging appsWriteJson = \"wrong\" />"; |
There was a problem hiding this comment.
Move the duplicate code to testutils.
…om/SuparnaSuresh/liberty-tools-vscode into issue381-ServerFeatureHoverSupport
aparnamichael
requested changes
Jan 28, 2025
|
Closing this as the test cases added in this PR now covered by PR #430 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.