Issue266 - automated test for view test report for gradle project #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation added
5 tasks
src/test/GradleTestDevModeActions.ts
Outdated
| @@ -248,26 +235,28 @@ it('start gradle with docker from liberty dashboard', async () => { | |||
|
|
|||
| }).timeout(350000); | |||
|
|
|||
| it('View test report for gradle project', async () => { | |||
| it('View test report for gradle project', async () => { | |||
There was a problem hiding this comment.
Fix the indentation.
There was a problem hiding this comment.
Addressed. Thanks
|
@SuparnaSuresh |
|
Updated the branch. Thanks |
src/test/GradleTestDevModeActions.ts
Outdated
| await utils.delay(1000); | ||
| console.log("Tabs opened: " + tabs.indexOf(constants.GRADLE_TEST_REPORT_TITLE)); | ||
|
|
||
| expect(tabs.indexOf(constants.GRADLE_TEST_REPORT_TITLE) > -1, "Gradle test report not found").to.equal(true); |
There was a problem hiding this comment.
Instead of checking for tab count > -1, can we close all the other tabs and open only the reports and check the tab header title?
it('View test report for gradle project', async () => {
// Close all the tabs in editor.
await new EditorView().closeAllEditors();
utils.delay(5000);
if ((process.platform === 'darwin')) {
//Function call to enter corresponding command in the command prompt to display test report for gradle project in mac
await viewTestReportForMac();
} else {
await utils.launchDashboardAction(item, constants.GRADLE_TR_DASHABOARD_ACTION, constants.GRADLE_TR_DASHABOARD_MAC_ACTION);
}
tabs = await new EditorView().getOpenEditorTitles();
await utils.delay(1000);
expect (tabs[0], "Gradle test report not found").to.equal(constants.GRADLE_TEST_REPORT_TITLE);
}).timeout(60000);
Also good to add an assert statement, if 'tabs' is empty.
There was a problem hiding this comment.
Addressed. Thanks
aparnamichael
requested changes
Jan 28, 2025
|
Incorporated review comments. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #266
Automated test case for View test report is enabled for gradle project.