-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oidc autoregistration #152
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
0bcdea1
update userguide for auto registration
brutif d4179db
add registration code
brutif 135a875
update types
brutif 39d6354
clean up format
brutif be2079f
propagate error
brutif b7f8f5c
interim updates
brutif 042e64f
rework route logic
brutif c15155e
clean up
brutif 095fd66
resolve merge conflict
brutif b277706
merge with integration
brutif f76b4b5
fix user-guide table
brutif 14d2ada
remove commented out code
brutif 855dc75
minor doc clarifications
brutif af43ecd
resolve merge conflict
brutif 5c39f20
improve rhsso secret explanation
brutif ee59b55
add liberty cr usage example
brutif 4b9bf76
move registration results from status to the secret
brutif f1d13b3
update for code review comments
brutif 4fd66f7
add updated crd
brutif 82da429
remove refs to autoreg secret that is no longer used
brutif 8f9d6bb
adjust registratiton json for IBM Cloud Verify
brutif e31a5e8
fix setting env var twice
brutif 15e4685
updates for code review, change client name registered at provider
brutif 325c964
resolve merge conflict
brutif 26f2773
resolve merge conflict, take2
brutif File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also add what the corresponding
RuntimeComponent
CR would be, and how it references this Secret? It would be good to visualize a working sample of what fields are needed in this auto-registration flow. Is there a specific naming convention that one must follow for this Secret to be auto discovered, or it can be named whatever we want as long as we reference it from the CR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The secret is an attribute of the OpenLibertyApplication,
sso.oidc[].autoRegisterSecret
, so it's not usable from the RuntimeComponent CR. It can be named whatever we want. I've updated the user guide to make the flow and who needs what (RedHat SSO vs. IBM Cloud Identity) more clear.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad - I meant to say the corresponding
OpenLibertyApplication
CR sample, that shows a complete CR usingautoRegisterSecret
. I really like theSecret
example, I think we just need the corresponding olapp CR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, got it. Added an example.