Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSO unit and e2e tests #174

Merged
merged 3 commits into from
Jun 17, 2020
Merged

Fix SSO unit and e2e tests #174

merged 3 commits into from
Jun 17, 2020

Conversation

edavidj
Copy link
Contributor

@edavidj edavidj commented Jun 15, 2020

What this PR does / why we need it?:

  • Updates tests to address changes in Oidc autoregistration #152
  • Doesn't introduce coverage for new features, that'll be tracked by another issue

Which issue(s) this PR fixes:

Fixes #173

@edavidj edavidj requested a review from leochr June 15, 2020 21:49
leochr
leochr approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @edavidj

@edavidj edavidj merged commit 0573eed into master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leochr leochr leochr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update SSO unit/e2e tests for recent changes
2 participants
@edavidj @leochr