-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Travis JS related tests #300
base: master
Are you sure you want to change the base?
Conversation
…refox via apt instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall seems fine, some minor nitpicks
directories: | ||
- $HOME/.npm | ||
- $HOME/.cache/pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this if we use Travis's built-in definitions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I'm not sure. At one point caching was only available in the pro one unless you configured it yourself! I don't know if it dealt with such subtleties too, so I'm tempted to leave it given it doesn't really do any harm.
before_cache: | ||
- rm -f $HOME/.cache/pip/log/debug.log # erase log | ||
- rm -f $HOME/.cache/pip/log/debug.log # erase log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still needed when using Travis's built-in definitions for the cache?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I'm not sure. At one point caching was only available in the pro one unless you configured it yourself! I don't know if it dealt with such subtleties too, so I'm tempted to leave it given it doesn't really do any harm.
No description provided.