-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User datasets, general styling and layouts, getting query started, and various filtering and sorting #3279
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3279 +/- ##
==========================================
+ Coverage 47.02% 47.41% +0.38%
==========================================
Files 583 587 +4
Lines 36945 37276 +331
Branches 1174 1243 +69
==========================================
+ Hits 17372 17673 +301
- Misses 19386 19416 +30
Partials 187 187 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, I added a few comments with some suggestions.
packages/openneuro-app/src/scripts/users/components/dataset-card.tsx
Outdated
Show resolved
Hide resolved
packages/openneuro-app/src/scripts/users/user-datasets-view.tsx
Outdated
Show resolved
Hide resolved
packages/openneuro-app/src/scripts/users/user-datasets-view.tsx
Outdated
Show resolved
Hide resolved
@nellh I would love to request another review. I think this is good except for the query for user datasets. I have some questions about that. |
No description provided.