Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User datasets, general styling and layouts, getting query started, and various filtering and sorting #3279

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

thinknoack
Copy link
Contributor

No description provided.

@thinknoack thinknoack marked this pull request as draft January 15, 2025 19:12
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 32 lines in your changes missing coverage. Please review.

Project coverage is 47.41%. Comparing base (b85d755) to head (ca6c9e8).

Files with missing lines Patch % Lines
.../scripts/users/components/user-dataset-filters.tsx 86.62% 21 Missing ⚠️
...s/openneuro-app/src/scripts/users/dataset-card.tsx 94.21% 7 Missing ⚠️
.../openneuro-app/src/scripts/utils/user-datasets.tsx 93.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3279      +/-   ##
==========================================
+ Coverage   47.02%   47.41%   +0.38%     
==========================================
  Files         583      587       +4     
  Lines       36945    37276     +331     
  Branches     1174     1243      +69     
==========================================
+ Hits        17372    17673     +301     
- Misses      19386    19416      +30     
  Partials      187      187              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nellh nellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, I added a few comments with some suggestions.

@thinknoack thinknoack marked this pull request as ready for review January 23, 2025 18:53
@thinknoack
Copy link
Contributor Author

@nellh I would love to request another review. I think this is good except for the query for user datasets. I have some questions about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants