Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Require events.tsv for non-rest tasks #3318

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

effigies
Copy link
Contributor

@effigies effigies commented Feb 1, 2025

Promotes EVENTS_TSV_MISSING to an error.

This may end up with some false positives. We should be able to do some additional filtering based on path, but if the logic gets complicated then this would be a good use case for patching the schema.

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.03%. Comparing base (25a7401) to head (51c64e5).

Files with missing lines Patch % Lines
...openneuro-app/src/scripts/workers/schema.worker.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3318      +/-   ##
==========================================
- Coverage   47.03%   47.03%   -0.01%     
==========================================
  Files         583      583              
  Lines       36954    36955       +1     
  Branches     1174     1174              
==========================================
  Hits        17382    17382              
- Misses      19385    19386       +1     
  Partials      187      187              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant