Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sh/rc-cgroup.sh: add openrc. prefix the cgroupv2 path #681

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

ncopa
Copy link
Contributor

@ncopa ncopa commented Dec 15, 2023

Some services, like docker, creates and manages /sys/fs/cgroup/ themselves. Avoid conflict with the openrc created cgroup path by adding a openrc. prefix.

Fixes: #680

@donob4n
Copy link

donob4n commented Dec 15, 2023

It seems that it needs more changes for be fully coherent.

Some services, like docker, creates and manages /sys/fs/cgroup/<service>
themselves. Avoid conflict with the openrc created cgroup path by adding
a `openrc.` prefix.

Fixes: OpenRC#680
@Forza-tng
Copy link
Contributor

Forza-tng commented Dec 26, 2023

Perhaps add a rc.conf variable for the openrc. prefix?

Would it make sense to create an opemrc group and nest all services below?

@williamh
Copy link
Contributor

williamh commented Jan 4, 2024

Hi,

I just applied this patch locally to test it and restarted a service.
I found that the old group for the service existed along side the new group after the restart.
e.g. /sys/fs/cgroup/ and /sys/fs/cgroup/openrc. both existed.
I was able to remove the old cgroup successfully.
Should we add something to this pr to removeit?

@williamh williamh merged commit 97689d6 into OpenRC:master Jan 9, 2024
5 checks passed
@ncopa ncopa deleted the cgroup2 branch January 11, 2024 13:30
@ncopa
Copy link
Contributor Author

ncopa commented Jan 11, 2024

Hi,

I just applied this patch locally to test it and restarted a service. I found that the old group for the service existed along side the new group after the restart. e.g. /sys/fs/cgroup/ and /sys/fs/cgroup/openrc. both existed. I was able to remove the old cgroup successfully. Should we add something to this pr to removeit?

Not sure its worth it. Its only a one time problem during upgrade that a reboot will "fix".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openrc and docker cgroup v2 path conflict
4 participants