Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CombineLatest #16

Merged
merged 7 commits into from
Dec 28, 2023
Merged

Implement CombineLatest #16

merged 7 commits into from
Dec 28, 2023

Conversation

Kyle-Ye
Copy link
Member

@Kyle-Ye Kyle-Ye commented Dec 28, 2023

Close #11

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (f746dc3) 96.84% compared to head (13c9369) 96.04%.

Files Patch % Lines
...nCombine/Publishers/Publishers.CombineLatest.swift 86.93% 29 Missing ⚠️
...ources/OpenCombine/Publishers/Publishers.Zip.swift 87.80% 5 Missing ⚠️
Sources/OpenCombine/Helpers/Violations.swift 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   96.84%   96.04%   -0.81%     
==========================================
  Files         106      107       +1     
  Lines        8079     8260     +181     
==========================================
+ Hits         7824     7933     +109     
- Misses        255      327      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kyle-Ye Kyle-Ye merged commit a7315a9 into main Dec 28, 2023
10 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/combine-latest branch December 28, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CombineLatest support
3 participants