While recording: show BLE sensor name instead of address.

Fixes #1796.
OpenTracksApp · Dec 26, 2023 · 8f5388e · 8f5388e
1 parent 81a7882
commit 8f5388e
Show file tree

Hide file tree

Showing 13 changed files with 14 additions and 34 deletions.
diff --git a/src/main/java/de/dennisguse/opentracks/sensors/BluetoothConnectionManager.java b/src/main/java/de/dennisguse/opentracks/sensors/BluetoothConnectionManager.java
@@ -139,11 +139,11 @@ synchronized void connect(Context context, Handler handler, @NonNull BluetoothDe
 
         bluetoothGatt = device.connectGatt(context, false, connectCallback, BluetoothDevice.TRANSPORT_AUTO, 0, handler);
 
-        observer.onConnect(sensorHandler.createEmptySensorData(bluetoothGatt.getDevice().getAddress()));
+        observer.onConnect(sensorHandler.createEmptySensorData(device.getAddress(), device.getName()));
     }
 
     private synchronized void clearData() {
-        observer.onDisconnect(sensorHandler.createEmptySensorData(bluetoothGatt.getDevice().getAddress()));
+        observer.onDisconnect(sensorHandler.createEmptySensorData(bluetoothGatt.getDevice().getAddress(), bluetoothGatt.getDevice().getName()));
     }
 
     synchronized void disconnect() {

diff --git a/src/main/java/de/dennisguse/opentracks/sensors/BluetoothHandlerBarometricPressure.java b/src/main/java/de/dennisguse/opentracks/sensors/BluetoothHandlerBarometricPressure.java
@@ -22,7 +22,7 @@ public List<ServiceMeasurementUUID> getServices() {
     }
 
     @Override
-    public Aggregator<?, ?> createEmptySensorData(String address) {
+    public Aggregator<?, ?> createEmptySensorData(String address, String name) {
         return null; //TODO
     }
 

diff --git a/src/main/java/de/dennisguse/opentracks/sensors/BluetoothHandlerCyclingCadence.java b/src/main/java/de/dennisguse/opentracks/sensors/BluetoothHandlerCyclingCadence.java
@@ -24,8 +24,8 @@ public List<ServiceMeasurementUUID> getServices() {
     }
 
     @Override
-    public AggregatorCyclingCadence createEmptySensorData(String address) {
-        return new AggregatorCyclingCadence(address);
+    public AggregatorCyclingCadence createEmptySensorData(String address, String name) {
+        return new AggregatorCyclingCadence(address, name);
     }
 
     @Override

diff --git a/src/main/java/de/dennisguse/opentracks/sensors/BluetoothHandlerCyclingDistanceSpeed.java b/src/main/java/de/dennisguse/opentracks/sensors/BluetoothHandlerCyclingDistanceSpeed.java
@@ -26,8 +26,8 @@ public List<ServiceMeasurementUUID> getServices() {
     }
 
     @Override
-    public AggregatorCyclingDistanceSpeed createEmptySensorData(String address) {
-        return new AggregatorCyclingDistanceSpeed(address);
+    public AggregatorCyclingDistanceSpeed createEmptySensorData(String address, String name) {
+        return new AggregatorCyclingDistanceSpeed(address, name);
     }
 
     @Override

diff --git a/src/main/java/de/dennisguse/opentracks/sensors/BluetoothHandlerManagerCyclingPower.java b/src/main/java/de/dennisguse/opentracks/sensors/BluetoothHandlerManagerCyclingPower.java
@@ -26,8 +26,8 @@ public List<ServiceMeasurementUUID> getServices() {
     }
 
     @Override
-    public AggregatorCyclingPower createEmptySensorData(String address) {
-        return new AggregatorCyclingPower(address);
+    public AggregatorCyclingPower createEmptySensorData(String address, String name) {
+        return new AggregatorCyclingPower(address, name);
     }
 
     @Override

diff --git a/src/main/java/de/dennisguse/opentracks/sensors/BluetoothHandlerManagerHeartRate.java b/src/main/java/de/dennisguse/opentracks/sensors/BluetoothHandlerManagerHeartRate.java
@@ -36,8 +36,8 @@ public List<ServiceMeasurementUUID> getServices() {
     }
 
     @Override
-    public AggregatorHeartRate createEmptySensorData(String address) {
-        return new AggregatorHeartRate(address);
+    public AggregatorHeartRate createEmptySensorData(String address, String name) {
+        return new AggregatorHeartRate(address, name);
     }
 
     @Override

diff --git a/src/main/java/de/dennisguse/opentracks/sensors/BluetoothHandlerRunningSpeedAndCadence.java b/src/main/java/de/dennisguse/opentracks/sensors/BluetoothHandlerRunningSpeedAndCadence.java
@@ -29,8 +29,8 @@ public List<ServiceMeasurementUUID> getServices() {
     }
 
     @Override
-    public AggregatorRunning createEmptySensorData(String address) {
-        return new AggregatorRunning(address);
+    public AggregatorRunning createEmptySensorData(String address, String name) {
+        return new AggregatorRunning(address, name);
     }
 
     @Override

diff --git a/src/main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorCyclingCadence.java b/src/main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorCyclingCadence.java
@@ -14,10 +14,6 @@ public class AggregatorCyclingCadence extends Aggregator<BluetoothHandlerCycling
 
     private final String TAG = AggregatorCyclingCadence.class.getSimpleName();
 
-    public AggregatorCyclingCadence(String sensorAddress) {
-        super(sensorAddress);
-    }
-
     public AggregatorCyclingCadence(String sensorAddress, String sensorName) {
         super(sensorAddress, sensorName);
     }

diff --git a/...main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorCyclingDistanceSpeed.java b/...main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorCyclingDistanceSpeed.java
@@ -17,10 +17,6 @@ public class AggregatorCyclingDistanceSpeed extends Aggregator<BluetoothHandlerC
 
     private Distance wheelCircumference;
 
-    public AggregatorCyclingDistanceSpeed(String sensorAddress) {
-        super(sensorAddress);
-    }
-
     public AggregatorCyclingDistanceSpeed(String sensorAddress, String sensorName) {
         super(sensorAddress, sensorName);
     }

diff --git a/src/main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorCyclingPower.java b/src/main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorCyclingPower.java
@@ -6,10 +6,6 @@
 
 public class AggregatorCyclingPower extends Aggregator<Power, Power> {
 
-    public AggregatorCyclingPower(String address) {
-        super(address);
-    }
-
     public AggregatorCyclingPower(String name, String address) {
         super(name, address);
     }

diff --git a/src/main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorHeartRate.java b/src/main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorHeartRate.java
@@ -6,10 +6,6 @@
 
 public class AggregatorHeartRate extends Aggregator<HeartRate, HeartRate> {
 
-    public AggregatorHeartRate(String address) {
-        super(address);
-    }
-
     public AggregatorHeartRate(String name, String address) {
         super(name, address);
     }

diff --git a/src/main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorRunning.java b/src/main/java/de/dennisguse/opentracks/sensors/sensorData/AggregatorRunning.java
@@ -14,10 +14,6 @@ public final class AggregatorRunning extends Aggregator<BluetoothHandlerRunningS
 
     private static final String TAG = AggregatorRunning.class.getSimpleName();
 
-    public AggregatorRunning(String sensorAddress) {
-        super(sensorAddress);
-    }
-
     public AggregatorRunning(String sensorAddress, String sensorName) {
         super(sensorAddress, sensorName);
     }

diff --git a/src/main/java/de/dennisguse/opentracks/sensors/sensorData/SensorHandlerInterface.java b/src/main/java/de/dennisguse/opentracks/sensors/sensorData/SensorHandlerInterface.java
@@ -11,7 +11,7 @@ public interface SensorHandlerInterface {
 
     List<ServiceMeasurementUUID> getServices();
 
-    Aggregator<?, ?> createEmptySensorData(String address);
+    Aggregator<?, ?> createEmptySensorData(String address, String name);
 
     void handlePayload(SensorManager.SensorDataChangedObserver observer, ServiceMeasurementUUID serviceMeasurementUUID, String sensorName, String address, BluetoothGattCharacteristic characteristic);
 }