fix #1769 export overwrite existing files #1771
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found the cause of the broken .gpx exports.
As the tracks were duplicates (from test ex- and imports). The export all function wrote two times to the same file. The second time the content was slightly less bytes, so the first file was only partly overwritten resulting in a broken xml file.
We need to make sure the target file is properly overwritten (truncated at the beginning).
Solution:
https://stackoverflow.com/questions/56902845/how-to-properly-overwrite-content-of-file-using-android-storage-access-framework
@dennisguse do we have to do anything else if two tracks result in the same filename and overwriting each other while exporting?