Move all renew code to easyrsa-tools.lib #1103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Add EASYRSA_TOOLS_LIB_VERSION to easyrsa-tools.lib: 1.0-3.2.0 Increment major portion '1.0' to signify a new tools version. Record the corresponding EasyRSA version at time of release. Add place-holders for possible updates. Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
|
This PR will not be merged. Some cherry picking will be done. I have a much cleaner solution to the |
|
Closed as completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cuts 476 lines of seldom used code out of
easyrsa.A massive maintenance burden is lifted ... almost restoring v3.0.9 functionality.
The first reply I expect is:
easyrsa-tools.libstill requires maintenance.This is true .. However, the core functionality is far less of a burden downstream and the tools lib will be an add-on extra, when required.
Rename to
easyrsa.lib?Using a library this way could also lead to CA renewal (etc), in a less critical way.
All other tasks are generative,
renewis repetitive, this is a distinct difference of low level functionality.I vote to move it out.