draft for factory production #144
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvpm
commented
Jan 31, 2024
| void FactoryProducer::produce( | ||
| const fixed_point_t input_modifier, const fixed_point_t throughput_modifier, const fixed_point_t output_modifier | ||
| ) { | ||
| std::map<PopType const* const, fixed_point_t> employees_per_job {}; |
There was a problem hiding this comment.
This could be cached as a private field.
There was a problem hiding this comment.
Yeah this definitely should be cached, we'll also need it for tooltips
There was a problem hiding this comment.
I think tooltips should be calculated on demand. It saves a memory and ensures the tooltips are up to date.
wvpm
commented
Jan 31, 2024
| @@ -37,3 +44,64 @@ fixed_point_t FactoryProducer::get_average_profitability_last_seven_days() const | |||
|
|
|||
| return sum / (1 + profit_history_current); | |||
| } | |||
|
|
|||
| void FactoryProducer::produce( | |||
| const fixed_point_t input_modifier, const fixed_point_t throughput_modifier, const fixed_point_t output_modifier | |||
There was a problem hiding this comment.
I imagine the country calls some method on each state, which calls this method for each factory.
The country & state create the modifier values here.
wvpm
commented
Jan 31, 2024
wvpm
commented
Jan 31, 2024
Hop311
reviewed
Jan 31, 2024
| void FactoryProducer::produce( | ||
| const fixed_point_t input_modifier, const fixed_point_t throughput_modifier, const fixed_point_t output_modifier | ||
| ) { | ||
| std::map<PopType const* const, fixed_point_t> employees_per_job {}; |
There was a problem hiding this comment.
Yeah this definitely should be cached, we'll also need it for tooltips
wvpm
force-pushed
the
factory_turn
branch
3 times, most recently
from
f275652 to
57b7a64
Compare
wvpm
force-pushed
the
producer_types
branch
2 times, most recently
from
b004547 to
1c0505e
Compare
Merged
Hop311
added a commit
to Hop311/OpenVic-Simulation
that referenced
this pull request
Oct 13, 2024
First pass at pops (test pops and density mapmode)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: