refactor/code_cleanup #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove all references to self.tts within the playback thread to simplify code, this does not break mycroft module compat as it was not present there needs OpenVoiceOS/ovos-plugin-manager#195 for the cache cleaning
JarbasAl
force-pushed
the
refactor/revert_ovos_additions_to_playback_thread
branch
from
fdac406 to
8b1595f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor/revert_ovos_additions_to_playback_thread
remove all references to self.tts within the playback thread to simplify code, this does not break mycroft module compat as it was not present there
needs OpenVoiceOS/ovos-plugin-manager#195 for the cache cleaning