fix: logs and pipeline query api #636
Conversation
skip common_qa when checking intent via bus api
WalkthroughThe pull request introduces modifications to the intent services in the OVOS core. The changes primarily focus on the Changes
Sequence DiagramsequenceDiagram
participant IntentService
participant PadaciosoService
participant Skills
IntentService->>PadaciosoService: Load Pipeline
IntentService->>Skills: Handle Utterance
Skills-->>IntentService: Potential Responses
IntentService->>IntentService: Filter Pipelines
IntentService-->>Skills: Final Intent Matching
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (3)ovos_core/intent_services/converse_service.py (1)
The added debug log enhances system observability by tracking which skills are being attempted for conversation. ovos_core/intent_services/__init__.py (2)
The import statement is properly aliased and aligns with its usage in the
The changes improve the system by:
The modifications align with the PR objective to skip common_qa during intent checking via the bus API. Let's verify the impact of skipping these pipelines: Also applies to: 469-472 ✅ Verification successfulSkipping optional pipelines in handle_get_intent is safe The verification confirms that skipping common_qa, converse, and fallback pipelines in
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify that skipped pipelines are not critical for intent matching
# Test: Search for direct usage of skipped pipelines in intent matching
# Check for direct references to common_qa in intent matching
rg -l "common_qa.*intent" --type py
# Check for direct references to fallback pipelines in intent matching
rg -l "fallback_(high|medium|low).*intent" --type py
# Check for direct references to converse in intent matching
rg -l "converse.*intent" --type py
Length of output: 305 Script: #!/bin/bash
# Let's check the actual usage context of these pipelines
# Check fallback pipeline usage in stop service
rg "fallback_(high|medium|low).*intent" -A 5 -B 5 ovos_core/intent_services/stop_service.py
# Check converse intent usage in test files
rg "converse.*intent" -A 5 -B 5 test/end2end/session/test_get_response.py test/end2end/session/test_converse.py
# Let's also check the handle_get_intent implementation to understand the pipeline skipping
ast-grep --pattern 'def handle_get_intent($$$)'
Length of output: 7754 Script: #!/bin/bash
# Let's check the actual implementation of handle_get_intent to understand pipeline skipping
rg "def handle_get_intent" -A 20 ovos_core/intent_services/__init__.py
# Also check if these pipelines are used in any critical intent matching paths
rg "common_qa|fallback_(high|medium|low)|converse" -A 5 -B 5 ovos_core/intent_services/__init__.py
Length of output: 8270 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #636 +/- ##
==========================================
- Coverage 75.33% 72.30% -3.04%
==========================================
Files 15 15
Lines 3094 1585 -1509
==========================================
- Hits 2331 1146 -1185
+ Misses 763 439 -324
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
skip common_qa when checking intent via bus api
Summary by CodeRabbit
New Features
PadaciosoServicefor improved intent handling.Bug Fixes
Documentation