-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[utils/common] Warning when root user is used #241
Conversation
WalkthroughThe changes modify the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
utils/common.sh (1)
64-77
: Consider enhancing the warning message.While the confirmation loop is well-implemented, the warning message could be more specific about the risks.
Consider this enhanced version:
- echo -e "Best pratices don't recommend running the installer as root user!" + echo -e "WARNING: Running as root is not recommended due to security risks!" + echo -e "Running as root can lead to accidental system-wide changes or security vulnerabilities."Also, there's a typo in "pratices" that should be "practices".
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
utils/common.sh
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: shell-testing
🔇 Additional comments (1)
utils/common.sh (1)
54-54
: LGTM! Improved error message with security warning.The updated error message now properly warns users about the risks of running as root.
Summary by CodeRabbit
Bug Fixes
Security