feat/nice_date utils #42
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #42 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 66
Lines ? 16926
Branches ? 0
=====================================
Hits ? 0
Misses ? 16926
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -370,6 +374,39 @@ def nice_date_time(dt, lang='', now=None, use_24hour=False, | |||
| use_ampm) | |||
|
|
|||
|
|
|||
| @localized_function(run_own_code_on=[FunctionNotLocalizedError]) | |||
| def nice_day(dt, date_format='MDY', include_month=True, lang=""): | |||
There was a problem hiding this comment.
perhaps date_format should be an enum since there are only 3(?) valid options right now (MDY, DMY, YMD).
There was a problem hiding this comment.
can't hurt, but note this comes from mycroft.conf and the valid options are basically defined there, so let's define what the enum should contain clearly
| return "{} {}".format(month, dt.strftime("%d")) | ||
| else: | ||
| return "{} {}".format(dt.strftime("%d"), month) | ||
| return dt.strftime("%d") |
There was a problem hiding this comment.
just realized that a one digit day is formatted with "0x". I don't know if all TTS can handle that.
Better dt.strftime("%-d")
| else: | ||
| raise ValueError("invalid date_format") | ||
| return { | ||
| "date_string": dtstr, |
There was a problem hiding this comment.
I feel we should include abbreviations coming from
nice_month/nice_weekdaywith a changed signature
def nice_month(dt, abbreviation=False, lang=""):in both cases date_format is irrelevant (as is)
|
I'm merging this one and addressing feedback later as this is a direct port of utils used in the datetime skill, I want to merge the homescreen PR needing this to reduce the insane amount of log spam it produces, right now im focused on getting 0.0.7 core release out and dont have time to focus on LF |
MycroftAI#198